add-purpose-field-to-esi-lease #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there are some unit tests should be updated with a purpose field in lease: esi-leap/esi_leap/tests/objects/test_lease.py, esi_leap/tests/db/sqlalchemy/test_api.py, esi_leap/tests/manager/test_service.py |
skanthed
force-pushed
the
add-purpose-to-esi-leases
branch
from
a2f78dc
to
ff74cf6
Compare
|
Yes I am just working on that now @DanNiESh and will update the PR. |
skanthed
force-pushed
the
add-purpose-to-esi-leases
branch
from
ff74cf6
to
bb7ef8c
Compare
skanthed
force-pushed
the
add-purpose-to-esi-leases
branch
from
bb7ef8c
to
4b2cabf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.