Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "10510: remove support for relative pathing and schema setting normalization" #13597

Conversation

mkalish
Copy link
Collaborator

@mkalish mkalish commented Mar 6, 2024

Reverts #13530

This needs to be reverted until the code can handle ReportFile.schemaName lengths greater than 63 characters.

@mkalish mkalish requested a review from a team as a code owner March 6, 2024 11:59
Copy link

github-actions bot commented Mar 6, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

Copy link

github-actions bot commented Mar 6, 2024

Test Results

1 089 tests   1 085 ✅  5m 40s ⏱️
  131 suites      4 💤
  131 files        0 ❌

Results for commit 802c612.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 6, 2024

Integration Test Results

 52 files   52 suites   13m 25s ⏱️
358 tests 348 ✅ 10 💤 0 ❌
361 runs  351 ✅ 10 💤 0 ❌

Results for commit 802c612.

♻️ This comment has been updated with latest results.

@mkalish mkalish added the platform Platform Team label Mar 6, 2024
@mkalish mkalish enabled auto-merge (squash) March 6, 2024 15:41
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
59.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@mkalish mkalish merged commit 85866b1 into master Mar 6, 2024
3 of 4 checks passed
@mkalish mkalish deleted the revert-13530-platform/kalish/10510-cleanup-and-sop-translation-schema branch March 6, 2024 16:23
jeremy-page added a commit that referenced this pull request Mar 7, 2024
* Bump operations/slack-boltjs-app from `830717e` to `1c5340b`

Bumps [operations/slack-boltjs-app](https://github.com/JosiahSiegel/slack-boltjs-app) from `830717e` to `1c5340b`.
- [Release notes](https://github.com/JosiahSiegel/slack-boltjs-app/releases)
- [Commits](JosiahSiegel/slack-boltjs-app@830717e...1c5340b)

---
updated-dependencies:
- dependency-name: operations/slack-boltjs-app
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* update tf to valid staging chatops

* move file change summary to local action

* SC Onboarding also allow to replace FHS-2 and BHS-2

* exclude specific whole directories under operations

* Bump bridgecrewio/checkov-action from 12.2682.0 to 12.2683.0 (#13586)

Bumps [bridgecrewio/checkov-action](https://github.com/bridgecrewio/checkov-action) from 12.2682.0 to 12.2683.0.
- [Release notes](https://github.com/bridgecrewio/checkov-action/releases)
- [Commits](bridgecrewio/checkov-action@e1c43cb...1d2da02)

---
updated-dependencies:
- dependency-name: bridgecrewio/checkov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 10510: remove support for relative pathing, schema setting normalization, schema management SOP (#13530)

* 10510: remove support for relative pathing and schema setting normalization

* 10510: last mile cleanup while writing Sync SOP

* 10510: SOP for syncing schemas between environments

* fixup! 10510: SOP for syncing schemas between environments

* fixup! 10510: last mile cleanup while writing Sync SOP

* fixup! 10510: last mile cleanup while writing Sync SOP

* Update prime-router/docs/standard-operating-procedures/managing-translation-schemas-in-azure.md

* Correct code according to Micheal's review

* Response to Victor comment

* Bump bridgecrewio/checkov-action from 12.2683.0 to 12.2684.0 (#13600)

Bumps [bridgecrewio/checkov-action](https://github.com/bridgecrewio/checkov-action) from 12.2683.0 to 12.2684.0.
- [Release notes](https://github.com/bridgecrewio/checkov-action/releases)
- [Commits](bridgecrewio/checkov-action@1d2da02...3758458)

---
updated-dependencies:
- dependency-name: bridgecrewio/checkov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Revert "10510: remove support for relative pathing, schema setting normalizat…" (#13597)

This reverts commit 961162a.

* Bug: fix schema name to not exceed max width (#13594)

* Bug: fix schema name to not exceed max width

* fixup! Bug: fix schema name to not exceed max width

* Bump azure/login to V2 (#13602)

* update HI on where we're live (#13608)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Josiah Siegel <josiah.siegel@semanticbits.com>
Co-authored-by: Josiah Siegel <5522990+JosiahSiegel@users.noreply.github.com>
Co-authored-by: Ott Sathngam <ott.sathngam@gmail.com>
Co-authored-by: Michael Kalish <michael.kalish@focusconsulting.io>
Co-authored-by: Stephen Nesman <94193373+snesm@users.noreply.github.com>
Co-authored-by: James Gilmore <109554461+GilmoreA6@users.noreply.github.com>
jeremy-page added a commit that referenced this pull request Mar 13, 2024
* Bump operations/slack-boltjs-app from `830717e` to `1c5340b`

Bumps [operations/slack-boltjs-app](https://github.com/JosiahSiegel/slack-boltjs-app) from `830717e` to `1c5340b`.
- [Release notes](https://github.com/JosiahSiegel/slack-boltjs-app/releases)
- [Commits](JosiahSiegel/slack-boltjs-app@830717e...1c5340b)

---
updated-dependencies:
- dependency-name: operations/slack-boltjs-app
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* update tf to valid staging chatops

* move file change summary to local action

* SC Onboarding also allow to replace FHS-2 and BHS-2

* exclude specific whole directories under operations

* Bump bridgecrewio/checkov-action from 12.2682.0 to 12.2683.0 (#13586)

Bumps [bridgecrewio/checkov-action](https://github.com/bridgecrewio/checkov-action) from 12.2682.0 to 12.2683.0.
- [Release notes](https://github.com/bridgecrewio/checkov-action/releases)
- [Commits](bridgecrewio/checkov-action@e1c43cb...1d2da02)

---
updated-dependencies:
- dependency-name: bridgecrewio/checkov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 10510: remove support for relative pathing, schema setting normalization, schema management SOP (#13530)

* 10510: remove support for relative pathing and schema setting normalization

* 10510: last mile cleanup while writing Sync SOP

* 10510: SOP for syncing schemas between environments

* fixup! 10510: SOP for syncing schemas between environments

* fixup! 10510: last mile cleanup while writing Sync SOP

* fixup! 10510: last mile cleanup while writing Sync SOP

* Update prime-router/docs/standard-operating-procedures/managing-translation-schemas-in-azure.md

* Correct code according to Micheal's review

* Response to Victor comment

* Bump bridgecrewio/checkov-action from 12.2683.0 to 12.2684.0 (#13600)

Bumps [bridgecrewio/checkov-action](https://github.com/bridgecrewio/checkov-action) from 12.2683.0 to 12.2684.0.
- [Release notes](https://github.com/bridgecrewio/checkov-action/releases)
- [Commits](bridgecrewio/checkov-action@1d2da02...3758458)

---
updated-dependencies:
- dependency-name: bridgecrewio/checkov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Revert "10510: remove support for relative pathing, schema setting normalizat…" (#13597)

This reverts commit 961162a.

* Bug: fix schema name to not exceed max width (#13594)

* Bug: fix schema name to not exceed max width

* fixup! Bug: fix schema name to not exceed max width

* Bump azure/login to V2 (#13602)

* update HI on where we're live (#13608)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Josiah Siegel <josiah.siegel@semanticbits.com>
Co-authored-by: Josiah Siegel <5522990+JosiahSiegel@users.noreply.github.com>
Co-authored-by: Ott Sathngam <ott.sathngam@gmail.com>
Co-authored-by: Michael Kalish <michael.kalish@focusconsulting.io>
Co-authored-by: Stephen Nesman <94193373+snesm@users.noreply.github.com>
Co-authored-by: James Gilmore <109554461+GilmoreA6@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team
Projects
Development

Successfully merging this pull request may close these issues.

2 participants