SQLmap supports clean URLs #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bulkowy
previously approved these changes
Nov 2, 2023
bulkowy
reviewed
Nov 2, 2023
Co-authored-by: Dominik Tybura <bulexxd@gmail.com>
…Artemis-modules-extra into sqlmap-supports-clean-urls-
bulkowy
reviewed
Nov 13, 2023
| ) | ||
|
|
||
| random.shuffle(expanded_urls_with_example_values) | ||
| expanded_urls_with_example_values = expanded_urls_with_example_values[ |
There was a problem hiding this comment.
I would like for loop to end if len(expanded_urls) > config_value, no need for it to loop through stuff taht would be truncated anyway
There was a problem hiding this comment.
but we perform random.shuffle() on that to get a random sample of the urls
without that, we wouldn't consider the urls that appear at the bottom of the page
and this loop is fast, it doesn't perform any server interaction
bulkowy
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.