Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all ELF files are for Linux #55

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Not all ELF files are for Linux #55

merged 2 commits into from
Jan 23, 2023

Conversation

jasperla
Copy link
Contributor

This stops tagging all ELF files as runnable:linux and instead uses the more generic runnable:elf.

This stops tagging all ELF files as 'runnable:linux' and instead
sets attempts to determine the most appropriate 'platform' and uses
'elf' as the extension.
Copy link
Member

@nazywam nazywam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

There is a small breaking change (using runnable:linux:elf instead of runnable:linux as a tag for samples) but the new version will be consistent with other platforms so I think we can manage

@psrok1 psrok1 merged commit 3142429 into CERT-Polska:master Jan 23, 2023
@psrok1 psrok1 mentioned this pull request Jan 23, 2023
@jasperla jasperla deleted the elf branch January 24, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants