Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/various filetypes #69

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

r1d3th3wav3s
Copy link
Contributor

  • Improved logging
  • Adds detection of various file types
  • Improved detection of UTF-8 / ASCII files
  • Adds a unit test for UTF-8 files

Copy link
Member

@psrok1 psrok1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you also provide test files for added extensions: see https://github.com/CERT-Polska/karton-classifier/tree/master/tests/testdata

PS.: I've fixed few simple errors and linting + merged it with upstream changes, so please make a pull before applying yours.

karton/classifier/classifier.py Outdated Show resolved Hide resolved
karton/classifier/classifier.py Outdated Show resolved Hide resolved
karton/classifier/classifier.py Show resolved Hide resolved
karton/classifier/classifier.py Outdated Show resolved Hide resolved
@r1d3th3wav3s
Copy link
Contributor Author

updated my pull request (removed some too specific detections, added unit-tests9

Copy link
Member

@nazywam nazywam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
One small note - I think we should stick to - instead of _ in the "kind" fields. There isn't an official guide per se but looking at other filetypes we've used only - so far

karton/classifier/classifier.py Outdated Show resolved Hide resolved
karton/classifier/classifier.py Outdated Show resolved Hide resolved
karton/classifier/classifier.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants