Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mistune to 2.0.4. #68

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Update mistune to 2.0.4. #68

merged 2 commits into from
Sep 26, 2022

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Sep 24, 2022

I did this by comparing the API of 2.0.4 and 0.8.4 as well as scanning the source code.

Motivation

The nixpkgs package manager usually only keeps the latest version of a Python package around. Right now, karton-dashboard is broken in nixpkgs, and this update will restore it. It also moves to a version of mistune that is actively developed.

Testing

The code changes necessary seem simple enough that I put together this PR, but I do not have karton set up (e.g. Redis and S3) so have not tested this. Any help in that quarter would be very welcome.

Copy link
Member

@nazywam nazywam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@psrok1 psrok1 merged commit d0a2a1f into CERT-Polska:master Sep 26, 2022
@tjni tjni deleted the update-mistune branch September 26, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants