Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled YARA Signature Support #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

c3rb3ru5d3d53c
Copy link

Added support to use compiled YARA signatures

See Enhancement: #9

@nazywam nazywam self-requested a review May 2, 2021 13:44
@chivay
Copy link
Contributor

chivay commented May 10, 2021

Hi, thanks for the PR!
Do you have any specific use case for this feature? Are you experiencing some performance issues?
We're already compiling rules on karton startup and from our experience this shouldn't take a lot of time.

@nazywam
Copy link
Member

nazywam commented Jun 1, 2021

cc @c3rb3ru5d3d53c

@rakovskij-stanislav
Copy link

@c3rb3ru5d3d53c & @chivay

As I can see, there are 2 cases to use precompiled rules:

  • a bit speedup of starting yaramatcher.
  • binding compiled rules on certain platform, a bit minimization of troubles connected with rules leak. SO the trouble of non-cross-platformity is an advantage :)

But there is a problem: compiled yara rules will take up more disk space -> will be loaded to memory slowlier -> speedup of this solution may decrease.

I'm not a maintainer, but if this code does not complicate current use case of yaramatcher, it can be considered as ok :)

@TheDuchy
Copy link

TheDuchy commented Jan 19, 2022

bumping this pull req as I would also love to see it merged. :)

In our case it would help us import rules with ... difficult dependencies that fail to compile under Karton.

@c3rb3ru5d3d53c
Copy link
Author

c3rb3ru5d3d53c commented Mar 11, 2022

Hey guys, I'm willing to help get this merged, I'll be testing here again soon!

I had life stuff going when i made the PR last and had many other things on the go.

I'm back now and re-building a mwdb environment 🙏

The usecase I have is that I have a yara CI/CD pipeline that compiles our signatures and it's much easier to deliver a pre-compiled blob. I don't see any problem adding it as the code I have allows you to do both options, the user can decide 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants