Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose consumer version in KartonBind #69

Closed
psrok1 opened this issue Dec 17, 2020 · 1 comment · Fixed by #93
Closed

Expose consumer version in KartonBind #69

psrok1 opened this issue Dec 17, 2020 · 1 comment · Fixed by #93
Assignees

Comments

@psrok1
Copy link
Member

psrok1 commented Dec 17, 2020

Currently we expose only the library version used by Karton service. Consumer version can be exposed as well and shown in API.

@nazywam nazywam self-assigned this Jan 8, 2021
@nazywam
Copy link
Member

nazywam commented Jan 8, 2021

👍

I've taken a look and the only problem I see is that the version fieldname is already used for keeping the karton library version.
I don't think breaking compatibility would be very wise there so we probably have to decide on another name.
2 possible names I've came up with:

  • service_version
  • consumer_version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants