Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose service version in binds #93

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Conversation

nazywam
Copy link
Member

@nazywam nazywam commented Jan 11, 2021

Some time ago we've added a version field for new consumers, this PR exposes them in the bind stored in Redis so we can process these versions in other systems (like dashboard)

Open questions:

  • Should it be named service_version or consumer_version? (or something else)

Closes #69

Copy link
Member

@psrok1 psrok1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok!

@nazywam nazywam merged commit 43ce3ac into master Jan 12, 2021
@nazywam nazywam deleted the feature/expose-service-version branch January 12, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose consumer version in KartonBind
2 participants