Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade karton cli #100

Merged
merged 17 commits into from
Jan 12, 2021
Merged

Upgrade karton cli #100

merged 17 commits into from
Jan 12, 2021

Conversation

nazywam
Copy link
Member

@nazywam nazywam commented Jan 12, 2021 •
edited
Loading

Almost everything has been turned upside down

  • use subparser instead of arguments for the root handler
  • add a new configure option
  • setup logging
  • add a few utility arguments

msm-code
msm-code reviewed Jan 12, 2021
View reviewed changes
karton/core/main.py Outdated Show resolved Hide resolved
karton/core/main.py Outdated Show resolved Hide resolved
karton/core/main.py Outdated Show resolved Hide resolved
karton/core/main.py Outdated Show resolved Hide resolved
karton/core/main.py Outdated Show resolved Hide resolved
karton/core/main.py Outdated Show resolved Hide resolved
karton/core/main.py Outdated Show resolved Hide resolved
karton/core/main.py Show resolved Hide resolved
karton/core/main.py Outdated Show resolved Hide resolved
karton/core/main.py Show resolved Hide resolved
@nazywam nazywam requested a review from msm-code January 12, 2021 13:38
ITAYC0HEN
ITAYC0HEN suggested changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@ITAYC0HEN ITAYC0HEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

karton/core/main.py Outdated Show resolved Hide resolved
karton/core/main.py Outdated Show resolved Hide resolved
psrok1
psrok1 approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@psrok1 psrok1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Approved with some suggestions.

karton/core/main.py Outdated Show resolved Hide resolved
karton/core/main.py Outdated Show resolved Hide resolved
karton/core/main.py Outdated Show resolved Hide resolved
karton/core/main.py Outdated Show resolved Hide resolved
@nazywam nazywam merged commit 59f65cc into master Jan 12, 2021
@nazywam nazywam deleted the feature/revamp-cli branch January 12, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psrok1 psrok1 psrok1 approved these changes

@ITAYC0HEN ITAYC0HEN ITAYC0HEN approved these changes

@msm-code msm-code Awaiting requested review from msm-code

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nazywam @msm-code @psrok1 @ITAYC0HEN