implement status signaling #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change set adds the ability for karton instances to signal to downstream consumers about the beginning and ending of task execution. Signaling is performed by sending corresponding "status" tasks. Task signaling is enabled using the following entry in the karton configuration file: ``` [signaling] status = 1 ``` Task signaling is disabled by default.
chivay
reviewed
Apr 26, 2021
psrok1
reviewed
Apr 26, 2021
There was a problem hiding this comment.
Looks great 👍 Nice use of hooks.
I have only few comments according to the naming:
type:status=>type:karton.statusortype:karton.signaling? It would be nice to provide some separate "namespace" for internal tasks.begin/end=>task_begin/task_endto make some space for further signals
|
@psrok1 Good input regarding the proposed name changes. Let me update things accordingly. |
chivay
approved these changes
Apr 27, 2021
* use `ConfigParser.getboolean` * rename signaling status task identifiers
conitrade-as
force-pushed
the
feature/status-signaling
branch
from
1f05e4d
to
8efa746
Compare
conitrade-as
commented
Apr 27, 2021
| @@ -39,7 +39,7 @@ def __init__(self, config): | |||
| endpoint=config["minio"]["address"], | |||
| access_key=config["minio"]["access_key"], | |||
| secret_key=config["minio"]["secret_key"], | |||
| secure=bool(int(config["minio"].get("secure", True))), | |||
| secure=config.config.getboolean("minio", "secure", fallback=True), | |||
There was a problem hiding this comment.
I had to push again, since in the previous change set it read config.getboolean.
There was a problem hiding this comment.
Yeah, config.config is quite cumbersome. I think it should be simplified it in the future.
|
Tested manually, seems to be working! Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set adds the ability for karton instances to signal to downstream
consumers about the beginning and ending of task execution. Signaling is
performed by sending corresponding "status" tasks.
Task signaling is enabled using the following entry in the karton
configuration file:
Task signaling is disabled by default.