Correctly handle SIGINT/SIGTERM for graceful exit #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazywam
reviewed
Jul 19, 2022
| self._shutdown = True | ||
|
|
||
| @property | ||
| def shutdown(self): |
There was a problem hiding this comment.
Is there a chance that some users try to shut down the service on their own by setting this to True?
There was a problem hiding this comment.
I haven't seen that pattern, but we can expose it in more controlled way in a future.
nazywam
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signal handlers should not be set inside the constructor of Karton class, because in case of incorrect invocation:
KartonClass instance is set twice and
GracefulKillerdoesn't correctly fallback to default handler. I replaced it with context manager and raising own exception (HardShutdownInterrupt) in case of second try.In previous implementation, second try handler was spawned only when second SIGINT arrived. Should we do the same for SIGTERM?After short research I think hard shutdown should be implemented only for SIGINT.