S3 support #190
Merged
S3 support #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks for contribution! |
psrok1
reviewed
Jul 21, 2022
| @@ -46,8 +46,8 @@ def __init__( | |||
| self._load_from_env() | |||
|
|
|||
There was a problem hiding this comment.
I have doubts about backwards compatibility, because change in major section name might cause some troubles in fluent transition from 4.x.x to 5.x.x.
I would start with deprecation and add something like that:
Suggested change
| if self.has_section("minio") and not self.has_section("s3"): | |
| warning.warn("[minio] section in configuration is deprecated, replace it with [s3]", DeprecationWarning) | |
| self._config["s3"] = self._config["minio"] |
psrok1
reviewed
Jul 21, 2022
Co-authored-by: Paweł Srokosz <psrok1@gmail.com>
psrok1
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Great, thanks! 🎉 Added a bit better fallback and found that DeprecationWarnings are actually ignored outside __main__ (https://docs.python.org/3/library/exceptions.html#DeprecationWarning).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinIO is S3 compatible so it may make sense to use just S3 compatible lib instead of minio-py - this also allows to use other S3-compatibile storage such as amazon or ceph