Extended service information for non-consumer services #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrok1
force-pushed
the
feature/service-info
branch
from
2041bde
to
9eacb64
Compare
nazywam
reviewed
Feb 27, 2023
Co-authored-by: Michał Praszmo <michalpr@cert.pl>
nazywam
reviewed
Feb 27, 2023
nazywam
approved these changes
Feb 27, 2023
Co-authored-by: Michał Praszmo <michalpr@cert.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to have version information also for looping producers (feeders), log consumers and other services that are part of Karton pipeline.
In this PR I'm adding these informations as a part of client name in the following URI like format:
Client name is currently used only by consumers to count the replicas and track for abandoned non-persistent queues, so it's not a breaking change if we include extra information for non-consumers. Information is included to client name only if
KartonBase.with_service_infoclass attribute is set to True (False by default).Attached version information can be then displayed in Karton Dashboard (see also CERT-Polska/karton-dashboard#72)