Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize the codebase, reformat and improve performance #111

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Modernize the codebase, reformat and improve performance #111

wants to merge 24 commits into from

Commits on Nov 22, 2023

  1. Use only new-style class declarations

    @bswck
    bswck committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    ed7fcda View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Modernize type annotations 

    Changes overview:
- Use types from the built-in scope, not the deprecated ones like `typing.List`, `typing.Dict` etc. See [PEP 585](https://peps.python.org/pep-0585/) and [typing docs on built-in types aliases](https://docs.python.org/3/library/typing.html#aliases-to-built-in-types).
- Postpone type annotations evaluation in runtime. See [PEP 563](https://peps.python.org/pep-0563/).
- Use [PEP 604](https://peps.python.org/pep-0604/) `X | Y` union type syntax.
- Use [PEP 613](https://peps.python.org/pep-0613/) explicit type aliases.
- Use `typing.TYPE_CHECKING` to separate typing-related imports from the actual runtime requirements.
    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    197dca8 View commit details
    Browse the repository at this point in the history

  2. Consistently use double-quote strings

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    70c9438 View commit details
    Browse the repository at this point in the history

  3. Consistently use no-arg super() inside methods

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    a461978 View commit details
    Browse the repository at this point in the history

  4. Use pathlib

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    ed8b576 View commit details
    Browse the repository at this point in the history

  5. Use f-string mini-language for no-prefix hex

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4963240 View commit details
    Browse the repository at this point in the history

  6. Make some exprlists multiline with trailing commas

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    f3582cc View commit details
    Browse the repository at this point in the history

  7. Make use of next() default value argument

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    719610f View commit details
    Browse the repository at this point in the history

  8. Fix line length excess

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    bd57af3 View commit details
    Browse the repository at this point in the history

  9. Consistently use type(X) instead of X.__class__

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d16a2b7 View commit details
    Browse the repository at this point in the history

  10. Optimize byte-string operations

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    06b02ca View commit details
    Browse the repository at this point in the history

  11. Reorder imports 

    Via `isort .`
    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9855140 View commit details
    Browse the repository at this point in the history

  12. Remove constructor calls in no-message exceptions

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    30de802 View commit details
    Browse the repository at this point in the history

  13. Optimize is_config_better()

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    64187cd View commit details
    Browse the repository at this point in the history

  14. Prefer on-demand tuples to lists

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9316ccc View commit details
    Browse the repository at this point in the history

  15. Use inplace addition in apply_config_part()

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    3e1b0a7 View commit details
    Browse the repository at this point in the history

  16. Use attrgetter in ExtractorModules.__init__()

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    ac2d30a View commit details
    Browse the repository at this point in the history

  17. Use zip() in IDAVM.__setitem__()

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    1c5fc55 View commit details
    Browse the repository at this point in the history

  18. Use unpack operator in ProcessMemoryPE.store()

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    63c3cef View commit details
    Browse the repository at this point in the history

  19. Reformat with black

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    fb62db0 View commit details
    Browse the repository at this point in the history

  20. Make some imports typing-only

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    7275edd View commit details
    Browse the repository at this point in the history

  21. Remove unused pytest imports

    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    aa3b6ae View commit details
    Browse the repository at this point in the history

  22. Use r-value list unpacking in ExtractorModules() 

    Credit to @trag1c for finding this pure gold
    @bswck
    bswck committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e683b56 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Sort imports

    @bswck
    bswck committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    1b93874 View commit details
    Browse the repository at this point in the history