New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bigint.pack for odd-length hex integers #58

Merged

nazywam merged 2 commits into CERT-Polska:master from yunzheng:master

Mar 4, 2021

Contributor

yunzheng commented Feb 4, 2021

This fixes the following error when you bigint.pack() an integer that has an odd-length hex string, such as 1 or 1234 (0x4d2).

    def unhex(s: Union[str, bytes]) -> bytes:
>       return binascii.unhexlify(s)
E       binascii.Error: Odd-length string

yunzheng added 2 commits

February 4, 2021 16:22


          Fix Bigint.pack for odd-length hex integers

9cc605e


          Use int.to_bytes() instead of unhex()

8bae7e9

nazywam self-requested a review

March 3, 2021 12:06

nazywam approved these changes

View reviewed changes

Member

nazywam left a comment

Looks great, thanks!

nazywam merged commit e2f28b0 into CERT-Polska:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet