Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin yara-python v4.2.3 #86

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Pin yara-python v4.2.3 #86

merged 1 commit into from
Mar 28, 2023

Conversation

yankovs
Copy link
Contributor

@yankovs yankovs commented Mar 28, 2023

In version v4.2.3 of yara-python accessing strings of a yara.Match object returns list of tuples of the form (<offset>,<identifier>,<data>) as seen in docs. However, in new v4.3.0 they've abstracted it to return List[StringMatch], where StringMatch itself also has abstracted StringMatchInstance member.

Shouldn't be too hard to refactor, but in the meantime maybe it's best to pin

@yankovs
Copy link
Contributor Author

yankovs commented Mar 28, 2023

I literally have no idea why it chose to include changes to dnfile requirement in diff

@psrok1
Copy link
Member

psrok1 commented Mar 28, 2023

Thanks! I also think that the best we can do is to temporarily pin version.

@psrok1 psrok1 merged commit dd7b839 into CERT-Polska:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants