Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff with... and search doesn't work #883

Closed
1 of 4 tasks
psrok1 opened this issue Oct 17, 2023 · 0 comments · Fixed by #941
Closed
1 of 4 tasks

Diff with... and search doesn't work #883

psrok1 opened this issue Oct 17, 2023 · 0 comments · Fixed by #941
Labels
type:bug Something isn't working zone:frontend MWDB frontend tasks

Comments

@psrok1
Copy link
Member

psrok1 commented Oct 17, 2023

Environment information

  • MWDB version (from /about): v2.10.1
  • Installation method:
    • mwdb.cert.pl service
    • From PyPi (pip install mwdb-core)
    • From docker-compose
    • Other (please explain)
  • Plugins installed:

Behaviour the bug (what happened?)

When we use query in Diff with mode, we escape the Diff with mode and we're landing in regular search.

Expected behaviour

We should still be in Diff with mode after making a query.

Reproduction Steps

  1. Go to a blob
  2. Click on Diff with option
  3. Make a query e.g. by clicking on blob type to filter
  4. We're redirected to the regular search because the ?diff= part of query is lost
@psrok1 psrok1 added type:bug Something isn't working zone:frontend MWDB frontend tasks labels Oct 17, 2023
@psrok1 psrok1 linked a pull request Jul 12, 2024 that will close this issue
4 tasks
@psrok1 psrok1 closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working zone:frontend MWDB frontend tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant