Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't forget diff= parameter while searching in diff mode #941

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Jun 8, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

When "Diff with.." option is used, MWDB UI escapes from diff mode into standard mode when we use Search. It happens because setSearchParams forget about diff= argument in query parameters.

What is the new behaviour?

Fixed setSearchParams invocation to not lose other arguments while updating search params

Test plan

Closing issues

@psrok1 psrok1 added the type:bug Something isn't working label Jun 8, 2024
@psrok1 psrok1 merged commit 20b40b9 into master Jun 8, 2024
12 checks passed
@psrok1 psrok1 deleted the fix/blob-diffing branch June 8, 2024 15:45
@psrok1 psrok1 mentioned this pull request Jul 9, 2024
@psrok1 psrok1 linked an issue Jul 12, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diff with... and search doesn't work
1 participant