Fix: ISE 500 on concurrent tag addition #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msm-cert
approved these changes
Mar 12, 2024
| @@ -540,18 +540,24 @@ def get_tags(self): | |||
| for tag in db.session.query(Tag).filter(Tag.object_id == self.id).all() | |||
| ] | |||
|
|
|||
| def add_tag(self, tag_name, commit=True): | |||
| def get_tag(self, tag_name): | |||
There was a problem hiding this comment.
Add typing and docstring maybe?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
db_tag in self.tagsdoesn't work when db_tag is transient object and doesn't have primary key which is used for comparison.What is the new behaviour?
Object.add_tagcorrectly returns False in case of IntegrityError indicating that tag was already added (by concurrent transaction).