Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set custom upload size limit via NGINX_MAX_UPLOAD_SIZE env var in mwdb-web Docker image #930

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Mar 28, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • [ ] I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

  • we can't easily set client_max_body_size without building own image
  • nginx Docker image provides correct start-web.sh on its own which is then unnecessarily overridden by our Dockerfile

What is the new behaviour?

  • Added NGINX_MAX_UPLOAD_SIZE env reference to client_max_body_size option in nginx.conf.template
  • Set correct path for nginx.conf.template (/etc/nginx/templates/default.conf.template instead of /etc/nginx/conf.d/default.conf.template) and added default 50M in ENV directive.

Test plan

  • Check if setting works with no env value set and with custom value (I've done it during manual test of my changes)

Closing issues

closes #927

@psrok1 psrok1 requested a review from msm-cert March 28, 2024 12:12
@psrok1 psrok1 force-pushed the feature/nginx-upload-size-via-env branch from cc91033 to e2d529b Compare March 28, 2024 12:38
@psrok1 psrok1 merged commit 0573e0b into master Mar 28, 2024
12 checks passed
@psrok1 psrok1 deleted the feature/nginx-upload-size-via-env branch March 28, 2024 13:45
@psrok1 psrok1 mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] mwdb-web complains about too large body but max_upload_size isn't set to anything
2 participants