Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 'mwdb-core configure web' command after transition to Vite #966

Merged
merged 1 commit into from
Aug 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 13 additions & 16 deletions mwdb/cli/web.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
import pathlib
import shutil
import subprocess
import tempfile
Expand All @@ -20,27 +21,23 @@ def discover_web_plugins():


def npm_build_web(target_dir):
config_paths = [
"./package.json",
"./package-lock.json",
"./config-overrides.js",
"./public",
"./src",
]
paths_to_ignore = ["node_modules", ".gitignore"]

with tempfile.TemporaryDirectory() as context_dirname:
# Copy files to context directory
logger.info("Creating build context...")
for path in config_paths:
src = os.path.join(web_package_dir, path)
dst = os.path.join(context_dirname, path)
if os.path.isfile(src):
shutil.copy(src, dst)
elif os.path.isdir(src):
shutil.copytree(src, dst)
dst = pathlib.Path(context_dirname)
for path in pathlib.Path(web_package_dir).iterdir():
if path.name in paths_to_ignore:
continue
if path.is_file():
shutil.copy(path, dst / path.name)
elif path.is_dir():
shutil.copytree(path, dst / path.name)
else:
raise RuntimeError(
"Critical error: expected file {} doesn't exist".format(path)
f"Critical error: file {path} is not a regular file "
"nor directory"
)

# Run npm install for web core
Expand All @@ -66,5 +63,5 @@ def npm_build_web(target_dir):
shutil.rmtree(target_dir)

logger.info("Collecting artifacts to %s", target_dir)
shutil.move(os.path.join(context_dirname, "build"), target_dir)
shutil.move(os.path.join(context_dirname, "dist"), target_dir)
logger.info("Web application built successfully!")
Loading