Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detail about customization, tree sharing, and decision point scope #242

Merged
merged 7 commits into from
Jun 27, 2023
Merged

Add detail about customization, tree sharing, and decision point scope #242

merged 7 commits into from
Jun 27, 2023

Conversation

ahouseholder
Copy link
Contributor

Resolves #239
Resolves #223

@ahouseholder ahouseholder added this to the SSVC v2.1 milestone Jun 14, 2023
@ahouseholder ahouseholder self-assigned this Jun 14, 2023
@ahouseholder ahouseholder changed the title Feature/fix 239 Add detail about customization, tree sharing, and decision point scope Jun 16, 2023
j---
j--- approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@j--- j--- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good. I don't have any suggestions for improvement, it's well organized, concisely written, and flows well.

cgyarbrough
cgyarbrough approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@cgyarbrough cgyarbrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes as submitted. We have discussed these previously.

@ahouseholder ahouseholder merged commit b41acd6 into main Jun 27, 2023
ahouseholder added a commit that referenced this pull request Jun 30, 2023
@ahouseholder
Merge branch 'feature/fix-246' of https://github.com/CERTCC/SSVC into…
33e0c5a 
… feature/fix-246

* 'feature/fix-246' of https://github.com/CERTCC/SSVC:
  add subsubsection header for tree versioning
  Update link to SSVC_Provision.schema.json
  Update link to SSVC_Computed.schema.json
  Update 055_decision-points_2.md (#250)
  Two small typo fixes (#253)
  Replace Utility with Automatable in Deployer tree (#248)
  Add detail about customization, tree sharing, and decision point scope (#242)
  add text to point ahead to "Information Changes over Time"
  bulletize list

# Conflicts:
#	ssvc-calc/SSVC_Computed.schema.json
#	ssvc-calc/SSVC_Provision.schema.json
@ahouseholder ahouseholder deleted the feature/fix_239 branch June 30, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j--- j--- j--- approved these changes

@cgyarbrough cgyarbrough cgyarbrough approved these changes

@ehatleback ehatleback Awaiting requested review from ehatleback

Assignees

@ahouseholder ahouseholder

Labels
None yet
Projects
None yet
Milestone
SSVC v2.1
Development

Successfully merging this pull request may close these issues.

Add description of Decision Point Scope and Decision Tree Scope to Customization Guidance
3 participants
@ahouseholder @j--- @cgyarbrough