Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc for box2001 #509

Closed
JFLemieux73 opened this issue Aug 25, 2020 · 2 comments
Closed

Doc for box2001 #509

JFLemieux73 opened this issue Aug 25, 2020 · 2 comments
Labels
Documentation

Comments

@JFLemieux73
Copy link
Contributor

The doc says that coriolis=0 for this test case. It should be f=1.46e-4. I am testing this right now and the code is fine and consistent with Hunke 2001.
@phil-blain
Copy link
Member

Indeed, the option file for box2001 has coriolis = 'constant' :

CICE/configuration/scripts/options/set_nml.box2001

Line 22 in e5ff1f2

coriolis = 'constant'

and this is hardcoded to 1.46e-4:

CICE/cicecore/cicedynB/dynamics/ice_dyn_shared.F90

Lines 172 to 173 in e5ff1f2

if (trim(coriolis) == 'constant') then
fcor_blk(i,j,iblk) = 1.46e-4_dbl_kind ! Hibler 1979, N. Hem; 1/s

I can do a quick PR to fix the doc.

@JFLemieux73
Copy link
Contributor Author

Please do.

phil-blain added a commit to phil-blain/CICE that referenced this issue Aug 25, 2020
@phil-blain
doc: correct description of box2001 test
bf88274 
The documentation states that this test case sets 'coriolis' to zero,
but 'configuration/scripts/options/set_nml.box2001' sets 'coriolis' to 'constant'.
Fix the documentation to be in line with the code.

Closes CICE-Consortium#509

Reported-by: Jean-François Lemieux <jean-francois.lemieux@canada.ca>
phil-blain added a commit to phil-blain/CICE that referenced this issue Aug 25, 2020
@phil-blain
doc: correct description of box2001 test
55e2b3d 
The documentation states that this test case sets 'coriolis' to zero,
but 'configuration/scripts/options/set_nml.box2001' sets 'coriolis' to 'constant'.
Fix the documentation to be in line with the code.

Closes CICE-Consortium#509

Reported-by: Jean-François Lemieux <jean-francois.lemieux@canada.ca>
phil-blain added a commit to phil-blain/CICE that referenced this issue Aug 25, 2020
@phil-blain
doc: correct description of box2001 test
1b6ec41 
The documentation states that this test case sets 'coriolis' to zero,
but 'configuration/scripts/options/set_nml.box2001' sets 'coriolis' to 'constant'.
Fix the documentation to be in line with the code.

While at it, add the correct unit for the Coriolis parameter (in both places
where it appears in the documentation).

Closes CICE-Consortium#509

Reported-by: Jean-François Lemieux <jean-francois.lemieux@canada.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JFLemieux73 @phil-blain