Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate CESM pond option #393

Merged
merged 4 commits into from
Jul 31, 2022
Merged

Deprecate CESM pond option #393

merged 4 commits into from
Jul 31, 2022

Conversation

dabail10
Copy link
Contributor

@dabail10 dabail10 commented Jul 18, 2022 •
edited
Loading

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Deprecate the CESM Pons
  • Developer(s):
    dabail10 (D. Bailey)
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    160 measured results of 160 total results
    159 of 160 tests PASSED
    0 of 160 tests PENDING
    1 of 160 tests MISSING data
    0 of 160 tests FAILED
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    This removes tr_pond_cesm and all code related to it. Now in a CPP UNDEPRECATE_CESMPONDS. This will break CICE. However, all base_suite tests (cheyenne/intel) are bfb. The set_nml.cesmponds option was removed from the testsuite. Note that tr_pond_cesm was also removed from the default icepack_in as well. Documentation has been updated with notes that this is deprecated. The one test that failed is missing baseline.

PASS cheyenne_intel_restart_col_1x1_snwgrain_snwITDrdg build
PASS cheyenne_intel_restart_col_1x1_snwgrain_snwITDrdg initialrun
PASS cheyenne_intel_restart_col_1x1_snwgrain_snwITDrdg run
PASS cheyenne_intel_restart_col_1x1_snwgrain_snwITDrdg test
MISS cheyenne_intel_restart_col_1x1_snwgrain_snwITDrdg compare icepack.76ecd418d2.220716-085004 missing-data

apcraig
apcraig approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to remove the CESM ponds documentation now, later, or just continue to note it's been deprecated in the documentation?

@eclare108213
Copy link
Contributor

eclare108213 commented Jul 28, 2022 via email •
edited
Loading

@apcraig apcraig merged commit 5f5fec5 into CICE-Consortium:main Jul 31, 2022
eclare108213 added a commit to E3SM-Project/Icepack that referenced this pull request Aug 1, 2022
@apcraig @dabail10 @eclare108213
Deprecate 0-layer, CESMponds; update to Consortium main (#2)
6210dbd 
* Deprecate CESM pond option (CICE-Consortium#393)

* Deprecate CESM pond option

* Update comments in documentation

* Deprecate 0-layer thermodynamics (CICE-Consortium#394)


* 0-layer deprecation - initial

* update doc

* update test options and abort if ktherm=0

* deprecate old ridging participation and redistribution functions

* Revert "deprecate old ridging participation and redistribution functions"

This reverts commit 8aa2f36.

Co-authored-by: Tony Craig <apcraig@users.noreply.github.com>

Co-authored-by: David A. Bailey <dbailey@ucar.edu>
Co-authored-by: Elizabeth Hunke <eclare@lanl.gov>
@phil-blain phil-blain mentioned this pull request Aug 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

@apcraig apcraig apcraig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dabail10 @eclare108213 @apcraig