Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD fixes for conservation #495

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
28d8396
Fixes for freshwater and salt conservation
dabail10 May 30, 2024
3f9b25f
Fix heat conservation and rearrange rside computation
dabail10 Jul 24, 2024
d0334c8
Also fix tracer vicen_init
dabail10 Jul 24, 2024
f66423a
One more fix for the FSD and update the driver.
dabail10 Jul 29, 2024
1cd7f7f
The character array does not need to be different at each point. Fixe…
dabail10 Jul 30, 2024
fed338c
Change the floe boundaries to be the same for all points
dabail10 Jul 30, 2024
77e43af
Clean up some comments
dabail10 Jul 30, 2024
c9ad3bc
Use ktherm=1 when sw is ccsm3
dabail10 Aug 15, 2024
b82474e
Remove spatial index on wavefreq and dwavefreq
dabail10 Aug 21, 2024
4104292
fix some spaces
dabail10 Aug 21, 2024
88a417b
Remove spatial index for local wave_spectrum_profile
dabail10 Aug 21, 2024
003aa6f
Remove spatial index for local wave_spectrum_profile
dabail10 Aug 21, 2024
c4f2f9c
Remove spatial index for local wave_spectrum_profile
dabail10 Aug 21, 2024
3c07803
Remove spatial index for local wave_spectrum_profile
dabail10 Aug 21, 2024
8925988
clean up driver code
dabail10 Aug 21, 2024
a3f6fbd
clean up driver code
dabail10 Aug 21, 2024
bfbc456
clean up driver code
dabail10 Aug 21, 2024
896190d
clean up driver code
dabail10 Aug 21, 2024
b6f35ad
clean up driver code
dabail10 Aug 21, 2024
1dbe211
Fix heat conservation and rearrange rside computation
dabail10 Jul 24, 2024
6daa191
One more fix for the FSD and update the driver.
dabail10 Jul 29, 2024
6732ac3
The character array does not need to be different at each point. Fixe…
dabail10 Jul 30, 2024
901b259
Change the floe boundaries to be the same for all points
dabail10 Jul 30, 2024
8c32f9f
Clean up some comments
dabail10 Jul 30, 2024
65910c0
Remove spatial index on wavefreq and dwavefreq
dabail10 Aug 21, 2024
664436d
clean up driver code
dabail10 Aug 21, 2024
19be00b
clean up driver code
dabail10 Aug 21, 2024
54dc9a1
clean up driver code
dabail10 Aug 21, 2024
b7270c6
Fix up some more nx related stuff
dabail10 Sep 20, 2024
7cde537
Bug fix from the BGC merge
dabail10 Sep 23, 2024
44f71bb
Some more fixes resulting from the BGC merge
dabail10 Sep 24, 2024
2258ead
Merge branch 'CICE-Consortium:main' into fsdfixes
dabail10 Oct 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions columnphysics/icepack_fsd.F90
Original file line number Diff line number Diff line change
Expand Up @@ -540,9 +540,6 @@ subroutine fsd_lateral_growth (dt, aice, &
vi0new_lat = vi0new * lead_area / (c1 + aice/latsurf_area)
end if

! for history/diagnostics
frazil = vi0new - vi0new_lat

! lateral growth increment
if (vi0new_lat > puny) then
G_radial = vi0new_lat/dt
Expand All @@ -564,7 +561,6 @@ subroutine fsd_lateral_growth (dt, aice, &

! Use remaining ice volume as in standard model,
! but ice cannot grow into the area that has grown laterally
vi0new = vi0new - vi0new_lat
tot_latg = SUM(d_an_latg(:))

end subroutine fsd_lateral_growth
Expand Down
Loading
Loading