Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bringing changes downstream #289

Merged
merged 287 commits into from
Aug 9, 2024
Merged

bringing changes downstream #289

merged 287 commits into from
Aug 9, 2024

Conversation

waveyboym
Copy link
Member

Description

Bringing changes downstream to keep this branch updated with develop

Fixes # (issue)

Type of change

Please delete options that are not relevant.

N/A

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

KamogeloMoeketse and others added 30 commits July 28, 2024 22:04
Rethakgetse-Manaka and others added 26 commits August 7, 2024 08:16
…e-Counter

Feature/backend/attendance counter
…ks-and-gotchas

chore: 🫨Stabilising backend with addition of centrifugo
…egration

Feat/mobile/occupancy integration
@waveyboym waveyboym added the type: bringing changes downstream Just bringing changes downstream label Aug 9, 2024
@waveyboym waveyboym self-assigned this Aug 9, 2024
Copy link

gitguardian bot commented Aug 9, 2024

⚠️ GitGuardian has uncovered 17 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13149987 Triggered Generic Password f0b6f78 frontend/occupi-mobile4/services/authservices.ts View secret
13149987 Triggered Generic Password 838fe0b frontend/occupi-mobile4/services/authservices.ts View secret
13149987 Triggered Generic Password e9cc470 frontend/occupi-mobile4/services/authservices.ts View secret
13149987 Triggered Generic Password fe2fd15 frontend/occupi-mobile4/services/authservices.ts View secret
13149987 Triggered Generic Password d6fc538 frontend/occupi-mobile4/services/authservices.ts View secret
13149987 Triggered Generic Password 3c76ba4 frontend/occupi-mobile4/services/authservices.ts View secret
13149987 Triggered Generic Password 4defd46 frontend/occupi-mobile4/services/authservices.ts View secret
13149987 Triggered Generic Password f5162a7 frontend/occupi-mobile4/services/authservices.ts View secret
13149987 Triggered Generic Password 91d331e frontend/occupi-mobile4/services/authservices.ts View secret
13307411 Triggered Generic High Entropy Secret 3baaa29 occupi-backend/counter/config.json View secret
13307411 Triggered Generic High Entropy Secret e2cce6e occupi-backend/counter/config.json View secret
13307412 Triggered Generic High Entropy Secret e2cce6e occupi-backend/counter/config.json View secret
13307412 Triggered Generic High Entropy Secret 3baaa29 occupi-backend/counter/config.json View secret
13307413 Triggered Generic Password e2cce6e occupi-backend/counter/config.json View secret
13307413 Triggered Generic Password 3baaa29 occupi-backend/counter/config.json View secret
13307414 Triggered Generic High Entropy Secret e2cce6e occupi-backend/counter/config.json View secret
13307414 Triggered Generic High Entropy Secret 3baaa29 occupi-backend/counter/config.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@waveyboym waveyboym merged commit f91393b into profile/backend/profiling Aug 9, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bringing changes downstream Just bringing changes downstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants