Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(phirgen): don't rely on args when qubits carries correct info #155

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix(phirgen): don't rely on args when qubits carries correct info #155

merged 1 commit into from
Mar 27, 2024

Conversation

qartik
Copy link
Member

@qartik qartik commented Mar 27, 2024

Description

Fixes #154

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog with any user-facing changes

@qartik qartik merged commit 50fa4e3 into main Mar 27, 2024
6 checks passed
@qartik qartik deleted the 154-conditional-measure-operations-incorrectly-converted-to-phir branch March 27, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neal-erickson neal-erickson neal-erickson approved these changes

@Asa-Kosto-QTM Asa-Kosto-QTM Asa-Kosto-QTM approved these changes

@cqc-alec cqc-alec Awaiting requested review from cqc-alec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditional measure operations incorrectly converted to PHIR
3 participants
@qartik @neal-erickson @Asa-Kosto-QTM