Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated model and storage class diagrams #147

Merged
merged 5 commits into from
Nov 12, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions docs/DeveloperGuide.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,9 @@ Given below is the Sequence Diagram for interactions within the `Logic` componen
image::DeletePersonSdForLogic.png[width="800"]

Given below is the Object Diagram that shows the associations between various objects within the `Logic` component for the Login functionality.
[[fig-LoginLogicObjectDiagram]]
.Associations between objects in the Logic Component for Login feature
image::LoginLogicObjectDiagram.PNG[width="800"]
image::LoginLogicObjectDiagram.png[width="800"]

. `LogicManager` creates a new instance of `AddressBookParser`, which takes in the user login input details.
. This results in the simultaneous instantiation of `LoginUserIdPasswordRoleCommandParser` object and the calling of parse() method on the object.
Expand Down Expand Up @@ -232,8 +233,9 @@ As a more OOP model, we can store a `Tag` list in `Address Book`, which `Person`
image:ModelClassBetterOopDiagram.png[width="800"]

Given below is the Object Diagram that shows the associations between various objects within the `Model` component for the Login functionality.
[[fig-LoginModelObjectDiagram]]
.Associations between objects in the Model Component for Login feature
image::LoginModelObjectDiagram.PNG[width="800"]
image::LoginModelObjectDiagram.png[width="800"]

. `filteredLoginDetails` will always show all accounts when `ModelManager` is first instantiated.
. Depending on the user input during login, `filteredLoginDetails` will be gradually filtered according to matching user id first, followed by user password and then, user role.
Expand All @@ -254,8 +256,9 @@ The `Storage` component,
* can save the Address Book data in xml format and read it back.

Given below is the Object Diagram that shows the associations between various objects within the `Storage` component for the new account creation functionality.
[[fig-LoginStorageObjectDiagram]]
.Associations between objects in the Storage Component for account creation feature
image::LoginStorageObjectDiagram.PNG[width="800"]
image::LoginStorageObjectDiagram.png[width="800"]

. `XmlAccount` is instantiated, with the appropriate account details as parameters for the new `XmlAccount` object.
. An `List<XmlAccount>` object is instantiated, with the previous `XmlAccount` object containing the new account's details to be added into the `List<XmlAccount>` object in `XmlSerializableLoginBook`.
Expand Down
Binary file modified docs/images/ModelClassBetterOopDiagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/StorageClassDiagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.