Skip to content

Commit

Permalink
More modification about the DG and portfolio
Browse files Browse the repository at this point in the history
  • Loading branch information
OscarZeng committed Nov 12, 2018
1 parent c82deee commit be33872
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
2 changes: 2 additions & 0 deletions docs/DeveloperGuide.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -2304,7 +2304,9 @@ should allow you to navigate to the hidden tags within the legend.
.. Prerequisites: Same as before. Just need to change the panel to see the effect.
.. Test case: Add any record with date in current month/ Delete any record with date in current month/ Edit any record to a date in current month/ Clear
.. Expected: Panel should show the welcome screen.

//tag::limitsManualTest[]

=== Adding a normal limit

. Adding a normal limit to the Financial Planner without the same time period limits inside.
Expand Down
12 changes: 3 additions & 9 deletions docs/team/OscarZeng.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ Users are able to record their finances and modify these records, set and modify
The product is based on Command Line Interface (CLI), users are able input their commands and related information at the TextBox.
Graphic User Interface is used for displaying statistic and other information, which will provide user with a clear and direct understanding about their financial status.
This product is user-friendly, the command can be automatically completed, limits will check automatically and report any exceeded limits' details.
It is also an effective and helpful product, users are able to find check their records and limits, generate summary for any period of time and export the record
to excel file to further manage these data and import excel file back.

This project is under the NUS CS2113 (Software Engineering & Object-Oriented Programming) module.
This module provides students with basic knowledge about Object-Oriented Programming and necessary software engineering training.
Expand All @@ -25,7 +23,6 @@ As a group we decided to morph the original product into FinancialPlanner.

== Summary of contributions

To better develop the product, each group member was assigned a main feature to develop.
I made significant contribution to the product by constructing the spending limit functions.
Detailed information about my contributions is listed below.

Expand Down Expand Up @@ -57,10 +54,7 @@ A new xml file will be created to store all the limits. It required an in-depth
=== `completed` *Major enhancement #2*: added the ability to set the monthly limit.

** What it does: allows the user to set the continuous monthly limit which will always check the total spending for the
current month. For example, if the limit was set to be 200 at April, the limit will keep checking the total spend in April.
When the time comes to the May, the limit will no longer check spends in April, instead, the limit
will keep checking the total spend of May until the last second of May.
The user will be reminded if the monthly limits have been exceeded and the monthly limit will always be placed at the top of limits' information.
current month. The user will be reminded if the monthly limits have been exceeded and the monthly limit will always be placed at the top of limits' information.
** Justification:This feature improves the product significantly because the user will be able to make continuous limit for every month. Since user may not
want to set the limit for every month, this function will provide the user with a convenient method to manage their monthly spend without entering
similar commands every month.
Expand Down Expand Up @@ -103,7 +97,7 @@ https://nuscs2113-ay1819s1.github.io/dashboard/#=undefined&search=oscarzeng[osca
*** Update limit related content and of Developer Guide.

** Community:
*** PRs reviewed. [Examples: ]
*** PRs reviewed. [Examples: https://github.com/CS2113-AY1819S1-T09-4/main/pull/199[1], https://github.com/CS2113-AY1819S1-T09-4/main/pull/195[2]]
*** Contributed to discussions in Whatsapp group.
*** Reported bugs and suggestions for other teams in the class both in Whatsapp and Github.
(Examples: https://github.com/CS2113-AY1819S1-T16-1/main/issues/267[1], https://github.com/CS2113-AY1819S1-T16-1/main/issues/272#event-1952348734[2])
Expand All @@ -126,7 +120,7 @@ include::../UserGuide.adoc[tag=limitfeatures]

include::../DeveloperGuide.adoc[tag=limitfeatures]

include::../DeveloperGuide.adoc[tag=limitUserCase]
https://github.com/CS2113-AY1819S1-T09-4/main/blob/Latest_UGDG_Update/docs/DeveloperGuide.adoc#13-use-case-create-a-normal-limit-for-a-period-of-time-or-a-day[LimitUserCase]

include::../DeveloperGuide.adoc[tag=limitsManualTest]

Expand Down

0 comments on commit be33872

Please sign in to comment.