Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 entity opportunity card 1 #25

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

pujiacheng
Copy link
Contributor

No description provided.

@pujiacheng pujiacheng linked an issue Nov 21, 2022 that may be closed by this pull request
@Winterequiem
Copy link
Contributor

The variables in this class are not encapsulated (private, protected) and the variable names do not follow naming conventions (camel case) so moneychange should be moneyChange and cardname as cardName. Since ChanceCard and CommunityCard is inheriting from OpportunityCard, they have by default the variables of the parent constructor (moneyChange and cardName, these variables should be protected so they can be inherited) so there is no need to define those variables in the child classes. Call the parent constructor with super(cardName, moneyChange) and have the parent class have a constructor that takes in the two variable and assign them to the instance variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity: Opportunity card
3 participants