Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compromise fix for windows build: display cmd behind gui app #19

Merged
merged 1 commit into from
Apr 20, 2023
Merged

compromise fix for windows build: display cmd behind gui app #19

merged 1 commit into from
Apr 20, 2023

Conversation

teemukataja
Copy link
Contributor

@teemukataja teemukataja commented Apr 20, 2023 •
edited
Loading

release v1.3.1

The Windows executable crashes, because pyinstaller is hiding the console (does not affect linux or mac, or when running with python)

  • compromise fix for windows: don't hide cmd
    • fix it better later by refactoring how the logging works

@teemukataja teemukataja added the bug Something isn't working label Apr 20, 2023
@teemukataja teemukataja self-assigned this Apr 20, 2023
@teemukataja teemukataja merged commit fd04b15 into master Apr 20, 2023
@teemukataja teemukataja deleted the fix/windows-build-temporary-compromise branch April 20, 2023 10:57
@teemukataja teemukataja mentioned this pull request Apr 27, 2023
Closed
This was referenced May 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankdots blankdots blankdots approved these changes

Assignees

@teemukataja teemukataja

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teemukataja @blankdots