Add formatter option to add custom formatters using the CLI #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
changed the title
| var path = require("path"); | ||
| var fullPath = path.resolve(process.cwd(), options.formatter); | ||
|
|
||
| var customFormatter = require(fullPath); |
There was a problem hiding this comment.
This line could throw exception. Catch it and return exitcode = 1?
SimenB
changed the title
|
I like this feature. Would be nice to have this merged :) |
|
I guess it's OK having such a feature, but we need more people to help with the development. |
|
@XhmikosR what do you mean, "more people"? This thing is really just exposing part of the programmatic API through the CLI. It's missing tests, I know, could probably write them if you want (unsure how you test the CLI itself) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't written any tests in case you are not interested in this.
The use case is to provide formatters over npm, instead of maintaining them within CSSLint core.
Usage:
I'm currently trying to throw together a custom reporter (based on jshint-stylish), which is the one used in the SS. If I could publish it to npm, it's release-cycle is not dependent on this.
The format of the
formatter-options is just a path (relative to wherecsslintis called) than can be required, and resolves into a formatter.EDIT: I published the formatter on npm. https://www.npmjs.com/package/csslint-stylish
npm i csslint-stylish, and then the command in the Screenshot should work to use the formatter from npm.npm linkwould make the node call cleaner, but meh