Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy typing #881

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix mypy typing #881

merged 1 commit into from
Jul 22, 2024

Conversation

tpazderka
Copy link
Collaborator

@tpazderka tpazderka commented Jul 22, 2024 •
edited
Loading

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

Close #880

@tpazderka tpazderka requested a review from schlenk July 22, 2024 09:17
@tpazderka tpazderka self-assigned this Jul 22, 2024
schlenk
schlenk approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@schlenk schlenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. I do not think the minor signature changes should cause any issues here.

@tpazderka tpazderka merged commit 829ee11 into master Jul 22, 2024
9 checks passed
@tpazderka tpazderka deleted the fix-mypy branch July 22, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlenk schlenk schlenk approved these changes

Assignees

@tpazderka tpazderka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix mypy
2 participants
@tpazderka @schlenk