DM-5722: Add table client-side sorting #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| height='calc(100% - 42px)' | ||
| sortInfo={sortInfo} | ||
| //tableStore={tableStore} | ||
| /> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Adding the sorting functionality simplified FitsHeaderViewer a lot.
There was a problem hiding this comment.
Just test FitsHeader, the sorting works. Nice job. I have a lot to learn, especially, the lodash, I never though of using it. Look at Loi's code, I found that get is very handy for searching something.
There was a problem hiding this comment.
In which situations do we sort on the client? Does it have implications for XYPlot or image, connected to a table (because they are sharing highlightedIdx)?
There was a problem hiding this comment.
Unrelated to sorting: I noticed that some comments in Fits header show as "null". It might be better to show no value instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see this in TablePanel options and fits header dialog.