Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require ftorch when coupling #134

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

jatkinson1000
Copy link
Member

Closes #133

It came up in #124 that some linking could pass undetected for the examples as CMake does not currently 'REQUIRE' FTorch.

This PR changes that for the examples (which are then pulled into the tests) and in the online coupling guidance.

@jatkinson1000 jatkinson1000 self-assigned this Jun 5, 2024
@jatkinson1000 jatkinson1000 changed the title Require ftorch egs Require ftorch when coupling Jun 5, 2024
@jatkinson1000 jatkinson1000 force-pushed the require-ftorch-egs branch 2 times, most recently from 8d68146 to 65b56df Compare June 5, 2024 10:21
@jwallwork23
Copy link
Contributor

Hm so this implies we need to build the tests separately from FTorch? Doable but means we have two build steps.

Either that or perhaps we can use POST_BUILD. I wonder if this is relevant? https://stackoverflow.com/questions/50913377/cmake-add-custom-command-post-build-depends-option-is-ignored

@jatkinson1000
Copy link
Member Author

My feelings are that this is not a priority, so can perhaps be put on a backburner for now - I had hoped it would be a 1-line change, but that does not seem the case. 😅

That said, don't let it stop you looking if you are interested!

I'm softening on it being a necessity to build tests as a one-shot with CMake - maybe having a separate "build tests" step wouldn't be an issue as one still has to follow a separate "run tests" step? I still think separating tests from examples (even if they use the same code) is sensible, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make FTorch REQUIRED in the examples
2 participants