Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate, but deprecate, the 'sleep' input #210

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Conversation

CasperWA
Copy link
Owner

@CasperWA CasperWA commented Nov 1, 2023

Fixes #209

A (deprecation) warning is emitted if the sleep input is specified.

The value will still be used, but only if pre_sleep is either not defined or is equal to its default value.
sleep's default value has been reset to an empty string (used to be '5').


From a test CI run with sleep set, it is seen that the warning will be shown in the CI workflow summary:
image

Furthermore, the warning will be shown in the workflow:
image

@CasperWA CasperWA enabled auto-merge (squash) November 2, 2023 00:04
@CasperWA CasperWA merged commit 22ba026 into main Nov 2, 2023
11 checks passed
@CasperWA CasperWA deleted the cwa/fix-209-sleep-input branch November 2, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reinstate and deprecate the sleep input
1 participant