Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #276 :
Until now, the validator handled the case that the URI inside an I3DM was padded with
0x00
(zero) characters. But the specification saysSo the validator has to handle the case that the URI is padded with
0x20
(space) characters.One question is still open: Should the validator consider it as an ERROR when the URI (i.e. the payload) is padded with
0x00
characters instead of spaces?Right now, it silently allows that. But sticking to the specification text, I'd say "Yes, this should be an error!".
If this is confirmed, I'd update this PR to treat this as an error (and this aspect has to be reviewed in the
3d-tiles-tools
in the context of CesiumGS/3d-tiles-tools#45 )