Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator setup #8

Merged
merged 1 commit into from
Oct 4, 2016
Merged

Validator setup #8

merged 1 commit into from
Oct 4, 2016

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Oct 4, 2016

Rounded out the project structure and add some utility functions borrowed from #4.

For the sake of time I'm just going to merge this now, but let me know if there are any issues I should address.

@lilleyse lilleyse merged commit a28cb15 into master Oct 4, 2016
@lilleyse lilleyse deleted the validator-setup branch October 4, 2016 18:39
@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 5, 2016

For the sake of time I'm just going to merge this now, but let me know if there are any issues I should address.

It's OK to run fast and loose, but instead of merging into master, make a validator-master branch; otherwise, keep master "ready to ship."

```
```
node ./bin/3d-tiles-tools.js gzip -i ./specs/data/Tileset/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this example needed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a copy-paste mistake, fixed now.

|Flag|Description|Required|
|----|-----------|--------|
|`-i`, `--input`|Input directory of the tileset.| :white_check_mark: Yes|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this optional (big +1 from me)? The example above does not have it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the wording for this so it is optional.

@lilleyse
Copy link
Contributor Author

lilleyse commented Oct 5, 2016

It's OK to run fast and loose, but instead of merging into master, make a validator-master branch; otherwise, keep master "ready to ship."

Alright, I'll do that from now on.

@lilleyse lilleyse mentioned this pull request Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants