-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator setup #8
Conversation
It's OK to run fast and loose, but instead of merging into |
``` | ||
``` | ||
node ./bin/3d-tiles-tools.js gzip -i ./specs/data/Tileset/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this example needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a copy-paste mistake, fixed now.
|Flag|Description|Required| | ||
|----|-----------|--------| | ||
|`-i`, `--input`|Input directory of the tileset.| :white_check_mark: Yes| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this optional (big +1 from me)? The example above does not have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the wording for this so it is optional.
Alright, I'll do that from now on. |
Rounded out the project structure and add some utility functions borrowed from #4.
For the sake of time I'm just going to merge this now, but let me know if there are any issues I should address.