Add options.id
to ModelExperimental
#10491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
id
option toModelExperimental
, allowing an object to be associated with the model when it is picked.Model
stores its pick ids in a_pickIds
array, but in ME they are also stored in_pipelineResources
(which I renamed from_resources
). Is it important to avoid the duplication here?For testing: this impacts the "Clamp to 3D Tiles" sandcastle, but that uses the
Entity
API. So to check that it works, go toModelVisualizer
and:Model.fromGltf
toModelExperimental.fromGltf
,getBoundingSphere
: just callBoundingSphere.clone(model.boundingSphere, result)
, no need to apply the model matrix to it.