Fix composite tile caching in ModelExperimental
#10524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composite (.cmpt) tiles were not handled correctly in
ModelExperimental
. Since theResourceCache
uses the content URL for cache keys, this is not enough to distinguish multiple models inside a single composite. This PR simply adds a?compositeIndex=i
query parameter to the request, that's enough to distinguish contents in the cache.Sandcastle for testing -- this includes both the
Composite
andComposite of Composite
models.As far as testing goes, if you set
enableModelExperimental
to true inComposite3DTIleContentSpec.js
the tests should still pass. Since #10346 will be added soon, it will be simpler to just wait until we set the global flag to true rather than duplicate tests just to remove half of them later.@j9liu could you review?