Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing private methods in PropertyTable for batch table hierarchy #10525

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

ptrgags
Copy link
Contributor

@ptrgags ptrgags commented Jul 8, 2022

There were a couple private methods of PropertyTable (and ModelFeatureTable) that were missing concerning the batch table hierarchy extension:

  • isClass()
  • isExactClass()
  • getExactClassName()

This fixes the 3D Tiles Batch Table Hierarchy when enableModelExperimental = true

Sandcastle for testing

@j9liu could you review?

@cesium-concierge
Copy link

Thanks for the pull request @ptrgags!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ptrgags ptrgags requested a review from j9liu July 8, 2022 18:32
@j9liu
Copy link
Contributor

j9liu commented Jul 8, 2022

@ptrgags looks good to me. The sandcastle works for me now, let me just run local tests to confirm they work and then I'll merge. Thanks!

@j9liu j9liu merged commit 122955d into main Jul 8, 2022
@j9liu j9liu deleted the property-table-hierarchy-api branch July 8, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants