Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove glTF 1.0 techniques from Photogrammetry Classification tileset #10594

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

ptrgags
Copy link
Contributor

@ptrgags ptrgags commented Jul 25, 2022

The 3D Tiles Photogrammetry Classification used a b3dm asset that uses glTF 1.0-style techniques (even though it was a glTF 2.0 model otherwise).

I manually converted the glTF asset to avoid using techniques (since those are deprecated). The Sandcastle linked above should work correctly (using Model).

Note that if you set enableModelExperimentalFeatures = true, the classification will not work because ClassificationModel does not yet work for ModelExperimental (it's an item on the roadmap: #10346), but it doesn't crash.

@j9liu could you review?

@ptrgags ptrgags requested a review from j9liu July 25, 2022 19:13
@cesium-concierge
Copy link

Thanks for the pull request @ptrgags!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@j9liu
Copy link
Contributor

j9liu commented Jul 25, 2022

@ptrgags looks good -- I confirmed that Model behaves just the same, and it doesn't cause a crash anymore for ModelExperimental. Thanks!

@j9liu j9liu merged commit d8883ab into main Jul 25, 2022
@j9liu j9liu deleted the classification-no-techniques branch July 25, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants