Fix for NodeJS with ESM modules #10694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @ggetz!
Reviewers, don't forget to make sure that:
|
There was a problem hiding this comment.
This looks good to me, @ggetz. I just have a couple of things I wanted to clarify.
|
Thanks @sanjeetsuhag! This should be ready for another look. |
sanjeetsuhag
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10684
NodeJS was failing to run ESM modules mainly because of a recent update to
zip.jswhich requiresTransformStreamto be defined. Looks like the zip.js maintainer addressed this and suggests either locking to2.4.xor adding a polyfill forTransformStream. Here, I've locked the package version.To prevent related issues from going unnoticed in the future, I added a
.mjsversion oftest.cjs, which is now run as part of CI.In doing so, I also caught two other issues. One was a faulty import, and the other was the use of
requireinResource.js. If I understand correctly, this is code that should only ever be executed in a NodeJS environment, and can be replaced with a dynamic import , satisfying both the ESM and CJS use cases.