Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GltfLoader updates #9595

Merged
merged 11 commits into from
Jun 16, 2021
Merged

GltfLoader updates #9595

merged 11 commits into from
Jun 16, 2021

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jun 6, 2021

This PR is extracting out some code from the model-loading branch, mostly related to glTF loading.

  • Rounded out some of the FeatureTexture API
  • Added full support for KHR_texture_transform
  • Improved state machine logic in GltfLoader
  • Added enums VertexAttributeSemantic and InstanceAttributeSemantic
  • Load instance attributes as typed arrays if "ROTATION" exists since quaternions need to be converted to rotation matrices on the CPU

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • ❔ CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

sanjeetsuhag
sanjeetsuhag reviewed Jun 14, 2021
View reviewed changes
Copy link
Contributor

@sanjeetsuhag sanjeetsuhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptrgags I've done a first pass on this.

Source/Scene/GltfLoader.js Outdated Show resolved Hide resolved
Source/Scene/GltfLoader.js Outdated Show resolved Hide resolved
Source/Scene/GltfLoader.js Outdated Show resolved Hide resolved
Source/Scene/GltfLoader.js Outdated Show resolved Hide resolved
Source/Scene/GltfLoader.js Outdated Show resolved Hide resolved
Source/Scene/GltfLoader.js Outdated Show resolved Hide resolved
Source/Scene/GltfLoader.js Outdated Show resolved Hide resolved
Source/Scene/GltfLoader.js Outdated Show resolved Hide resolved
Source/Scene/GltfLoader.js Outdated Show resolved Hide resolved
Source/Scene/VertexAttributeSemantic.js Outdated Show resolved Hide resolved
@ptrgags ptrgags mentioned this pull request Jun 15, 2021
Merged
@ptrgags
Copy link
Contributor

ptrgags commented Jun 15, 2021

@sanjeetsuhag updated!

sanjeetsuhag
sanjeetsuhag reviewed Jun 16, 2021
View reviewed changes
Source/Scene/GltfLoaderUtil.js Outdated Show resolved Hide resolved
Source/Scene/ModelComponents.js Outdated Show resolved Hide resolved
@ptrgags
Copy link
Contributor

ptrgags commented Jun 16, 2021

@sanjeetsuhag updated!

@sanjeetsuhag sanjeetsuhag mentioned this pull request Jun 16, 2021
Open
6 tasks
@sanjeetsuhag
Copy link
Contributor

Changes look good to me. Thanks @lilleyse and @ptrgags!

@sanjeetsuhag sanjeetsuhag merged commit c4f748e into master Jun 16, 2021
@sanjeetsuhag sanjeetsuhag deleted the gltf-loader-updates branch June 16, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjeetsuhag sanjeetsuhag sanjeetsuhag left review comments

@ptrgags ptrgags ptrgags left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilleyse @cesium-concierge @ptrgags @sanjeetsuhag