Skip to content

Commit

Permalink
quic: address recent coverity warnings
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52647
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
mhdawson authored and Ch3nYuY committed May 8, 2024
1 parent 4dcac61 commit cf255c5
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/quic/data.cc
Original file line number Diff line number Diff line change
Expand Up @@ -285,14 +285,14 @@ void QuicError::MemoryInfo(MemoryTracker* tracker) const {
QuicError QuicError::ForTransport(error_code code, std::string reason) {
QuicError error(std::move(reason));
ngtcp2_ccerr_set_transport_error(
&error.error_, code, error.reason_c_str(), reason.length());
&error.error_, code, error.reason_c_str(), error.reason().length());
return error;
}

QuicError QuicError::ForApplication(error_code code, std::string reason) {
QuicError error(std::move(reason));
ngtcp2_ccerr_set_application_error(
&error.error_, code, error.reason_c_str(), reason.length());
&error.error_, code, error.reason_c_str(), error.reason().length());
return error;
}

Expand All @@ -307,14 +307,14 @@ QuicError QuicError::ForIdleClose(std::string reason) {
QuicError QuicError::ForNgtcp2Error(int code, std::string reason) {
QuicError error(std::move(reason));
ngtcp2_ccerr_set_liberr(
&error.error_, code, error.reason_c_str(), reason.length());
&error.error_, code, error.reason_c_str(), error.reason().length());
return error;
}

QuicError QuicError::ForTlsAlert(int code, std::string reason) {
QuicError error(std::move(reason));
ngtcp2_ccerr_set_tls_alert(
&error.error_, code, error.reason_c_str(), reason.length());
&error.error_, code, error.reason_c_str(), error.reason().length());
return error;
}

Expand Down

0 comments on commit cf255c5

Please sign in to comment.