fix commands order to start UI #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willydouhard
approved these changes
Jun 24, 2023
|
Nice catch, thank you! |
|
Seems there is still room for improvement:
I love the project and believe a smooth guide will be a big welcome to future contributors. Please let me know if there is anything unclear. |
|
This is good feedback, thank you! Can you have a look @tpatel ? |
tpatel
added a commit
to tpatel/chainlit
that referenced
this pull request
Jul 3, 2023
- Introduce a conditional instead of relying on modifying the source code - Modify the contributing docs based on Chainlit#101
tpatel
added a commit
that referenced
this pull request
Jul 3, 2023
- Introduce a conditional instead of relying on modifying the source code - Modify the contributing docs based on #101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no
buildUiscript in/src/chainlit/frontend/package.jsonso the commands to start UI in CONTRIBUTING.md will not work. Should runbuildUiat repo root then cd into frontend folder.