Make OCPP library compatible with Android 8 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android 8's Jack has issues processing class files with lambda operations that implicitly use classes which are not part of the project, resulting in build failures. Replace the four occurrences where such lambdas are used with functionally identical but less shorthand code, so that the OCPP library will build for Android 8.
|
Please consider this pull request for merging into the master. It is only a minor change that helps compatibility a lot. |
|
I don't know why the integration test failed on Travis. Locally on my machine it passes both with and without my change!?! |
|
Where are my manners? Thank you for this contribution! :D I really appreciate that you share this knowledge and have taken extra effort to improved my little library. Thanks! The IT are unstable, I'll try to rerun them. My guess is, that Travis assigns minimal resources to the virtual machine that runs the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android 8's Jack has issues processing class files with lambda
operations that implicitly use classes which are not part of the
project, resulting in build failures.
Replace the four occurrences where such lambdas are used with
functionally identical but less shorthand code, so that the OCPP
library will build for Android 8.