Allow listVersion 0 in SendLocalListRequest #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OCPP 1.6 specification mentions no explicit value range for the listVersion field in the SendLocalListRequest, but specifies that 0 should be returned as the version in case the list is empty. Now there is no message to clear the local authorization list, so clearing the list can only be achieved with a SendLocalListRequest with an empty list, and that is a use case for listVersion 0. In fact the OCPP certification test tool employs such requests. Change SendLocalListRequest to allow listVersion 0 rather than only 1 or higher, and adapt the unit test accordingly. While at it, bump the version in build.gradle to "1.1" to match the one from pom.xml.
TVolden
approved these changes
Aug 19, 2022
|
Hi @robert-s-ubi , Thanks for your contribution. Everything looks good and I'm happy that you spotted the version inconsistency, which I missed. :) Sincerely, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OCPP 1.6 specification mentions no explicit value range for the
listVersion field in the SendLocalListRequest, but specifies that 0
should be returned as the version in case the list is empty. Now there
is no message to clear the local authorization list, so clearing the
list can only be achieved with a SendLocalListRequest with an empty
list, and that is a use case for listVersion 0. In fact the OCPP
certification test tool employs such requests.
Change SendLocalListRequest to allow listVersion 0 rather than only 1 or
higher, and adapt the unit test accordingly.
While at it, bump the version in build.gradle to "1.1" to match the one
from pom.xml.