Adding all Parameter for ClientCoreProfile factory #28
Conversation
|
Hi Steven, Thanks for your PR, it looks good. There's some problems with the CI. I'll investigate later.
|
|
Hi Thomas, I made another commit I would like to add. I implemented client side of Local Auth List Steven |
|
Hi Steven, Wow, thanks allot for your contribution. Thomas |
| @@ -187,11 +187,12 @@ public MeterValuesRequest createMeterValuesRequest(Integer connectorId, MeterVal | |||
| * @see StartTransactionRequest | |||
| * @see StartTransactionFeature | |||
| */ | |||
| public StartTransactionRequest createStartTransactionRequest(Integer connectorId, String idTag, Integer meterStart, Calendar timestamp) throws PropertyConstraintException { | |||
| public StartTransactionRequest createStartTransactionRequest(Integer connectorId, String idTag, Integer meterStart, int reservationId, Calendar timestamp) throws PropertyConstraintException { | |||
There was a problem hiding this comment.
The idea with the create metodes on the profile, has to help make a request with all the mandatory fields set.
The field reservatopmID wasn't a part of this method, since it's not mandatory.
I'd recommend removing it from this method and setting it on the return object locally.
| @@ -223,10 +224,11 @@ public StatusNotificationRequest createStatusNotificationRequest(Integer connect | |||
| * @param transactionId required. The identification of the transaction. | |||
| * @return an instance of {@link StopTransactionRequest}. | |||
| */ | |||
| public StopTransactionRequest createStopTransactionRequest(int meterStop, Calendar timestamp, int transactionId) { | |||
| public StopTransactionRequest createStopTransactionRequest(int meterStop, Calendar timestamp, Reason reason, int transactionId) { | |||
There was a problem hiding this comment.
Reason wasn't part of the parameters since it's not a mandatory field. See explanation above.
…arameter aren't manditory
|
Done, hopefully the CI will build now. |
|
Looks like it 😀 |
Also cleaned up if doesn't connect, it doesn't show the call stack every time